[Kotlin] Generate open classes and methods #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... I see this could clash with #1808. Maybe the |
I haven't checked this code, but you can use |
Closed
bendk
requested changes
Nov 7, 2023
| * @param noPointer Placeholder value so we can have a constructor separate from the default empty one that may be | ||
| * implemented for classes extending [FFIObject]. | ||
| */ | ||
| constructor(noPointer: NoPointer): super(noPointer) |
There was a problem hiding this comment.
Great docstring and I like the use of the singleton object to differentiate this from the regular constructor.
- Also make their methods open. - Make the `Pointer` in `FfiObject` optional. - Add a `constructor(noPointer: NoPointer)` to create a FFiObject with no pointer for fakes. - Remove redundant interfaces since they can be implemented, but not used in any way. - Add tests for fakes.
jmartinesp
force-pushed
the
kotlin-open-classes
branch
from
81e622a to
fafcc3e
Compare
bendk
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative implementation of #1782 , with the 1st approach @bendk proposed here:
The implementation changes are:
FFIObject.pointeris now nullable. I know it's not great, but it's necessary as far as I can tell and I haven't seen any issues with it so far.FFIObjectnow has an alternateconstructor(noPointer: NoPointer). I tried using an empty constructor or one withpointer: Pointer?as the only parameter, but it clashed with the code in generated classes.FFIObject.freeRustArcPtrimplementation in the different classes now does a null check before trying to free the pointer, so you don't need to override it in the fakes, and methods usingcallWithPointerwill unwrap the nullable value and throw aNullPointerExceptionif it doesn't exist.FooInterfaceand just pass it to afn bar(foo: Foo)function without aClassCastException, and the open class can now act as a kind of interface (again, I might be wrong about this, they could be restored). I did keep the interface for the trait interfaces and their impls.I added a few tests displaying how these open classes can be extended, used and not used in a real project.
I feel like this approach isn't as correct as the one in #1782 where you'd be forced to provide an alternative implementation for the interfaces that doesn't crash, but it's way simpler to maintain and the drawbacks I see as a lib user aren't that bad.